Re: [PATCH v1 net-next 5/6] net: mscc: ocelot: split register definitions to a separate file

Hi Colin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Colin-Foster/prepare-ocelot-for-external-interface-control/20211120-064530
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 520fbdf7fb19b7744e370d36d9244a446299ceb7
config: i386-randconfig-a002-20211118 (attached as .config)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a5f13354942bd393fe1014a9c1b3d34dd8ec5f52
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Colin-Foster/prepare-ocelot-for-external-interface-control/20211120-064530
        git checkout a5f13354942bd393fe1014a9c1b3d34dd8ec5f52
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mscc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:28:10: error: use of undeclared identifier 'vsc7514_ana_regmap'; did you mean 'ocelot_ana_regmap'?

           [ANA] = vsc7514_ana_regmap,
                   ^~~~~~~~~~~~~~~~~~
                   ocelot_ana_regmap
   include/soc/mscc/vsc7514_regs.h:11:18: note: 'ocelot_ana_regmap' declared here
   extern const u32 ocelot_ana_regmap[];
                    ^

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:29:9: error: use of undeclared identifier 'vsc7514_qs_regmap'; did you mean 'ocelot_qs_regmap'?

           [QS] = vsc7514_qs_regmap,
                  ^~~~~~~~~~~~~~~~~
                  ocelot_qs_regmap
   include/soc/mscc/vsc7514_regs.h:12:18: note: 'ocelot_qs_regmap' declared here
   extern const u32 ocelot_qs_regmap[];
                    ^

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:30:11: error: use of undeclared identifier 'vsc7514_qsys_regmap'; did you mean 'ocelot_qsys_regmap'?

           [QSYS] = vsc7514_qsys_regmap,
                    ^~~~~~~~~~~~~~~~~~~
                    ocelot_qsys_regmap
   include/soc/mscc/vsc7514_regs.h:13:18: note: 'ocelot_qsys_regmap' declared here
   extern const u32 ocelot_qsys_regmap[];
                    ^

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:31:10: error: use of undeclared identifier 'vsc7514_rew_regmap'; did you mean 'ocelot_rew_regmap'?

           [REW] = vsc7514_rew_regmap,
                   ^~~~~~~~~~~~~~~~~~
                   ocelot_rew_regmap
   include/soc/mscc/vsc7514_regs.h:14:18: note: 'ocelot_rew_regmap' declared here
   extern const u32 ocelot_rew_regmap[];
                    ^

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:32:10: error: use of undeclared identifier 'vsc7514_sys_regmap'; did you mean 'ocelot_sys_regmap'?

           [SYS] = vsc7514_sys_regmap,
                   ^~~~~~~~~~~~~~~~~~
                   ocelot_sys_regmap
   include/soc/mscc/vsc7514_regs.h:15:18: note: 'ocelot_sys_regmap' declared here
   extern const u32 ocelot_sys_regmap[];
                    ^

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:33:9: error: use of undeclared identifier 'vsc7514_vcap_regmap'; did you mean 'ocelot_vcap_regmap'?

           [S0] = vsc7514_vcap_regmap,
                  ^~~~~~~~~~~~~~~~~~~
                  ocelot_vcap_regmap
   include/soc/mscc/vsc7514_regs.h:16:18: note: 'ocelot_vcap_regmap' declared here
   extern const u32 ocelot_vcap_regmap[];
                    ^
   drivers/net/ethernet/mscc/ocelot_vsc7514.c:34:9: error: use of undeclared identifier 'vsc7514_vcap_regmap'; did you mean 'ocelot_vcap_regmap'?
           [S1] = vsc7514_vcap_regmap,
                  ^~~~~~~~~~~~~~~~~~~
                  ocelot_vcap_regmap
   include/soc/mscc/vsc7514_regs.h:16:18: note: 'ocelot_vcap_regmap' declared here
   extern const u32 ocelot_vcap_regmap[];
                    ^
   drivers/net/ethernet/mscc/ocelot_vsc7514.c:35:9: error: use of undeclared identifier 'vsc7514_vcap_regmap'; did you mean 'ocelot_vcap_regmap'?
           [S2] = vsc7514_vcap_regmap,
                  ^~~~~~~~~~~~~~~~~~~
                  ocelot_vcap_regmap
   include/soc/mscc/vsc7514_regs.h:16:18: note: 'ocelot_vcap_regmap' declared here
   extern const u32 ocelot_vcap_regmap[];
                    ^

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:36:10: error: use of undeclared identifier 'vsc7514_ptp_regmap'; did you mean 'ocelot_ptp_regmap'?

           [PTP] = vsc7514_ptp_regmap,
                   ^~~~~~~~~~~~~~~~~~
                   ocelot_ptp_regmap
   include/soc/mscc/vsc7514_regs.h:17:18: note: 'ocelot_ptp_regmap' declared here
   extern const u32 ocelot_ptp_regmap[];
                    ^

quoted

drivers/net/ethernet/mscc/ocelot_vsc7514.c:37:15: error: use of undeclared identifier 'vsc7514_dev_gmii_regmap'; did you mean 'ocelot_dev_gmii_regmap'?

           [DEV_GMII] = vsc7514_dev_gmii_regmap,
                        ^~~~~~~~~~~~~~~~~~~~~~~
                        ocelot_dev_gmii_regmap
   include/soc/mscc/vsc7514_regs.h:18:18: note: 'ocelot_dev_gmii_regmap' declared here
   extern const u32 ocelot_dev_gmii_regmap[];
                    ^
   10 errors generated.


vim +28 drivers/net/ethernet/mscc/ocelot_vsc7514.c

    26	
    27	static const u32 *ocelot_regmap[TARGET_MAX] = {
  > 28		[ANA] = vsc7514_ana_regmap,
  > 29		[QS] = vsc7514_qs_regmap,
  > 30		[QSYS] = vsc7514_qsys_regmap,
  > 31		[REW] = vsc7514_rew_regmap,
  > 32		[SYS] = vsc7514_sys_regmap,
  > 33		[S0] = vsc7514_vcap_regmap,
    34		[S1] = vsc7514_vcap_regmap,
    35		[S2] = vsc7514_vcap_regmap,
  > 36		[PTP] = vsc7514_ptp_regmap,
  > 37		[DEV_GMII] = vsc7514_dev_gmii_regmap,
    38	};
    39	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org