Thread (2 messages) 2 messages, 2 authors, 2021-11-19

Re: [PATCH linux-next] ipv6/esp6: Remove structure variables and alignment statements

flat view

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2021-11-19 08:37:10
Also in: lkml

On Thu, Nov 04, 2021 at 03:19:31AM +0000, cgel.zte@gmail.com wrote:
From: luo penghao <redacted>

The definition of this variable is just to find the length of the
structure after aligning the structure. The PTR alignment function
is to optimize the size of the structure. In fact, it doesn't seem
to be of much use, because both members of the structure are of
type u32.
So I think that the definition of the variable and the
corresponding alignment can be deleted, the value of extralen can
be directly passed in the size of the structure.

The clang_analyzer complains as follows:

net/ipv6/esp6.c:117:27 warning:

Value stored to 'extra' during its initialization is never read

Reported-by: Zeal Robot <redacted>
Signed-off-by: luo penghao <redacted>
Applied to ipsec-next, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help