[PATCH AUTOSEL 5.15 04/65] UNRPC: Return specific error code on kmalloc failure
From: Sasha Levin <sashal@kernel.org>
Date: 2021-11-16 19:18:14
Also in:
linux-nfs, lkml, stable
Subsystem:
kernel nfsd, sunrpc, and lockd servers, networking [general], nfs, sunrpc, and lockd clients, the rest · Maintainers:
Chuck Lever, Jeff Layton, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Trond Myklebust, Anna Schumaker, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2021-11-16 · [PATCH AUTOSEL 5.15 04/65] UNRPC: Return specific error code on kmalloc failure · Sasha Levin <sashal@kernel.org>
From: Yang Li <redacted> [ Upstream commit 458032fcfa91c8714859b1f01b9ac7dccea5d6cd ] Although the callers of this function only care about whether the return value is null or not, we should still give a rigorous error code. Smatch tool warning: net/sunrpc/auth_gss/svcauth_gss.c:784 gss_write_verf() warn: returning -1 instead of -ENOMEM is sloppy No functional change, just more standardized. Reported-by: Abaci Robot <redacted> Signed-off-by: Yang Li <redacted> Signed-off-by: J. Bruce Fields <redacted> Signed-off-by: Sasha Levin <sashal@kernel.org> --- net/sunrpc/auth_gss/svcauth_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 1f2817195549b..b87565b64928d 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c@@ -781,7 +781,7 @@ gss_write_verf(struct svc_rqst *rqstp, struct gss_ctx *ctx_id, u32 seq) svc_putnl(rqstp->rq_res.head, RPC_AUTH_GSS); xdr_seq = kmalloc(4, GFP_KERNEL); if (!xdr_seq) - return -1; + return -ENOMEM; *xdr_seq = htonl(seq); iov.iov_base = xdr_seq;
--
2.33.0