Thread (10 messages) flat view 10 messages, 4 authors, 2021-11-16

Re: [PATCH] tipc: use consistent GFP flags

From: Tadeusz Struk <hidden>
Date: 2021-11-16 16:40:57
Also in: lkml

On 11/15/21 05:00, patchwork-bot+netdevbpf@kernel.org wrote:
This patch was applied to netdev/net.git (master)
by David S. Miller[off-list ref]:

On Thu, 11 Nov 2021 12:59:16 -0800 you wrote:
quoted
Some functions, like tipc_crypto_start use inconsisten GFP flags
when allocating memory. The mentioned function use GFP_ATOMIC to
to alloc a crypto instance, and then calls alloc_ordered_workqueue()
which allocates memory with GFP_KERNEL. tipc_aead_init() function
even uses GFP_KERNEL and GFP_ATOMIC interchangeably.
No doc comment specifies what context a function is designed to
work in, but the flags should at least be consistent within a function.

[...]
Here is the summary with links:
   - tipc: use consistent GFP flags
     https://git.kernel.org/netdev/net/c/86c3a3e964d9

You are awesome, thank you!
Thanks, you are awesome too! ;)
Any feedback about the patch:
[PATCH v2] tipc: check for null after calling kmemdup

-- 
Thanks,
Tadeusz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help