Re: [PATCH 4/6] vhost_vsock: simplify vhost_vsock_flush()

From
Stefano Garzarella <sgarzare@redhat.com>
Date
2021-11-16 14:35:53
Also in
kvm, lkml, virtualization
Reply to
Andrey Ryabinin, 2021-11-15
On Mon, Nov 15, 2021 at 06:30:01PM +0300, Andrey Ryabinin wrote:
quoted hunk ↗ jump to hunk
vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev)
before vhost_work_dev_flush(&vsock->dev). This seems pointless
as vsock->vqs[i].poll.dev is the same as &vsock->dev and several flushes
in a row doesn't do anything useful, one is just enough.

Signed-off-by: Andrey Ryabinin <redacted>
---
drivers/vhost/vsock.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index b0361ebbd695..b4dcefbb7e60 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -707,11 +707,6 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file)
static void vhost_vsock_flush(struct vhost_vsock *vsock)
{
-	int i;
-
-	for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++)
-		if (vsock->vqs[i].handle_kick)
-			vhost_work_dev_flush(vsock->vqs[i].poll.dev);
	vhost_work_dev_flush(&vsock->dev);
}

-- 
2.32.0
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thread (19 messages) 19 messages, 6 authors, last reply 2021-12-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help