Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range
From: Alex Elder <hidden>
Date: 2021-11-11 21:25:29
Also in:
lkml
On 11/11/21 12:37 PM, Konrad Dybcio wrote:
The source group count was mistakenly assigned to both dst and src loops. Fix it to make IPA probe and work again.
Looks good. Oops. Reviewed-by: Alex Elder <redacted>
quoted hunk ↗ jump to hunk
Fixes: 4fd704b3608a ("net: ipa: record number of groups in data") Acked-by: AngeloGioacchino Del Regno <redacted> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> Signed-off-by: Konrad Dybcio <redacted> --- Changes since v1: - Add a "Fixes:" tag, R-b, A-b and fix up the commit message drivers/net/ipa/ipa_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c index e3da95d69409..06cec7199382 100644 --- a/drivers/net/ipa/ipa_resource.c +++ b/drivers/net/ipa/ipa_resource.c@@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa, return false; } - group_count = data->rsrc_group_src_count; + group_count = data->rsrc_group_dst_count; if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX) return false;