[PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

Subsystems: networking drivers, qcom ipa driver, the rest

STALE1731d LANDED: 3 (2M)

2 review trailers; landed in mainline as 27df68d579c6 on 2021-11-13.

3 messages, 3 authors, 2021-11-13 · open the first message on its own page

[PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

From: Konrad Dybcio <hidden>
Date: 2021-11-11 18:37:33

The source group count was mistakenly assigned to both dst and src loops.
Fix it to make IPA probe and work again.

Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
Acked-by: AngeloGioacchino Del Regno <redacted>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Konrad Dybcio <redacted>
---
Changes since v1:
- Add a "Fixes:" tag, R-b, A-b and fix up the commit message
 drivers/net/ipa/ipa_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
index e3da95d69409..06cec7199382 100644
--- a/drivers/net/ipa/ipa_resource.c
+++ b/drivers/net/ipa/ipa_resource.c
@@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
 				return false;
 	}
 
-	group_count = data->rsrc_group_src_count;
+	group_count = data->rsrc_group_dst_count;
 	if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
 		return false;
 
-- 
2.33.0

Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

From: Alex Elder <hidden>
Date: 2021-11-11 21:25:29

On 11/11/21 12:37 PM, Konrad Dybcio wrote:
The source group count was mistakenly assigned to both dst and src loops.
Fix it to make IPA probe and work again.
Looks good.  Oops.

Reviewed-by: Alex Elder <redacted>
quoted hunk
Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
Acked-by: AngeloGioacchino Del Regno <redacted>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Konrad Dybcio <redacted>
---
Changes since v1:
- Add a "Fixes:" tag, R-b, A-b and fix up the commit message
  drivers/net/ipa/ipa_resource.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
index e3da95d69409..06cec7199382 100644
--- a/drivers/net/ipa/ipa_resource.c
+++ b/drivers/net/ipa/ipa_resource.c
@@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
  				return false;
  	}
  
-	group_count = data->rsrc_group_src_count;
+	group_count = data->rsrc_group_dst_count;
  	if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
  		return false;
  

Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-13 04:20:27

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski [off-list ref]:

On Thu, 11 Nov 2021 19:37:24 +0100 you wrote:
The source group count was mistakenly assigned to both dst and src loops.
Fix it to make IPA probe and work again.

Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
Acked-by: AngeloGioacchino Del Regno <redacted>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Konrad Dybcio <redacted>

[...]
Here is the summary with links:
  - [v2] net/ipa: ipa_resource: Fix wrong for loop range
    https://git.kernel.org/netdev/net/c/27df68d579c6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help