Re: [PATCH v2 2/7] net: dsa: b53: Move struct b53_device to include/linux/dsa/b53.h
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-11-09 18:15:35
Also in:
lkml
On Tue, 9 Nov 2021 at 20:11, Florian Fainelli [off-list ref] wrote:
On 11/9/21 10:05 AM, Florian Fainelli wrote:quoted
On 11/9/21 1:50 AM, Martin Kaistra wrote:quoted
In order to access the b53 structs from net/dsa/tag_brcm.c move the definitions from drivers/net/dsa/b53/b53_priv.h to the new file include/linux/dsa/b53.h. Signed-off-by: Martin Kaistra <redacted> --- drivers/net/dsa/b53/b53_priv.h | 90 +---------------------------- include/linux/dsa/b53.h | 100 +++++++++++++++++++++++++++++++++ 2 files changed, 101 insertions(+), 89 deletions(-) create mode 100644 include/linux/dsa/b53.hAll you really access is the b53_port_hwtstamp structure within the tagger, so please make it the only structure exposed to net/dsa/tag_brcm.c.You do access b53_dev in the TX part, still, I would like to find a more elegant solution to exposing everything here, can you create a b53_timecounter_cyc2time() function that is exported to modules but does not require exposing the b53_device to net/dsa/tag_brcm.c? -- Florian
Switch drivers can't export symbols to tagging protocol drivers, remember? https://lore.kernel.org/netdev/20210908220834.d7gmtnwrorhharna@skbuf/ (local)