Re: [PATCH] module: Fix implicit type conversion
From: Miroslav Benes <mbenes@suse.cz>
Date: 2021-11-08 18:31:14
Also in:
bpf, lkml
[CCing Luis] Hi, On Fri, 29 Oct 2021, Jiasheng Jiang wrote:
The variable 'cpu' is defined as unsigned int. However in the for_each_possible_cpu, its values is assigned to -1. That doesn't make sense and in the cpumask_next() it is implicitly type conversed to int. It is universally accepted that the implicit type conversion is terrible. Also, having the good programming custom will set an example for others. Thus, it might be better to change the definition of 'cpu' from unsigned int to int.
Frankly, I don't see a benefit of changing this. It seems fine to me. Moreover this is not, by far, the only place in the kernel with the same pattern. Miroslav
quoted hunk ↗ jump to hunk
Fixes: 10fad5e ("percpu, module: implement and use is_kernel/module_percpu_address()") Signed-off-by: Jiasheng Jiang <redacted> --- kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/kernel/module.c b/kernel/module.c index 927d46c..f10d611 100644 --- a/kernel/module.c +++ b/kernel/module.c@@ -632,7 +632,7 @@ static void percpu_modcopy(struct module *mod, bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr) { struct module *mod; - unsigned int cpu; + int cpu; preempt_disable();-- 2.7.4