Re: [PATCH net v4] net: marvell: prestera: fix hw structure laid out

Hi Volodymyr,

On Fri, Nov 5, 2021 at 11:42 PM Volodymyr Mytnyk
[off-list ref] wrote:

quoted

quoted

From: Volodymyr Mytnyk <redacted>

The prestera FW v4.0 support commit has been merged
accidentally w/o review comments addressed and waiting
for the final patch set to be uploaded. So, fix the remaining
comments related to structure laid out and build issues.

Reported-by: kernel test robot <redacted>
Fixes: bb5dbf2cc64d ("net: marvell: prestera: add firmware v4.0 support")
Signed-off-by: Volodymyr Mytnyk <redacted>

The patch does not apply to the mainline kernel, so I can not test it there.
It does apply to linux-next, and m68k:allmodconfig builds there with the patch
applied. However, m68k:allmodconfig also builds in -next with this patch _not_
applied, so I can not really say if it does any good or bad.
In the meantime, the mainline kernel (as of v5.15-10643-gfe91c4725aee)
still fails to build.

        The mainline kernel doesn't have the base ("net: marvell: prestera: add firmware v4.0 support") commit yet, so the patch will not be applied.

Mainline has this broken commit as of Nov 2.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds