Thread (55 messages) 55 messages, 5 authors, 2021-11-05

Re: [PATCH v2 07/25] tcp: Use BIT() for OPTION_* constants

From: Leonard Crestez <hidden>
Date: 2021-11-03 22:19:12
Also in: linux-crypto, linux-kselftest, lkml

On 11/3/21 4:31 AM, David Ahern wrote:
On 11/1/21 10:34 AM, Leonard Crestez wrote:
quoted
Extending these flags using the existing (1 << x) pattern triggers
complaints from checkpatch.

Instead of ignoring checkpatch modify the existing values to use BIT(x)
style in a separate commit.

Signed-off-by: Leonard Crestez <redacted>
---
  net/ipv4/tcp_output.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
This one could be sent outside of this patch set since you are not
adding new values. Patch sets > 20 are generally frowned upon; sending
this one separately helps get the number down.
In the past I've seen maintainers pick small cleanups and fixes from 
longer series that otherwise need further discussion.

Not sure if this practice is also common for netdev so I posted this 
patch separately.

--
Regards,
Leonard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help