Thread (4 messages) 4 messages, 3 authors, 2021-11-16

Re: [PATCH] net/mlx5:using swap() instead of tmp variable

flat view

From: Roi Dayan <hidden>
Date: 2021-11-03 06:57:30
Also in: linux-rdma, lkml


On 2021-11-03 8:21 AM, Yihao Han wrote:
quoted hunk ↗ jump to hunk
swap() was used instead of the tmp variable to swap values

Signed-off-by: Yihao Han <redacted>
---
  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index 740cd6f088b8..d4b4f32603f2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
  	struct mlx5_ct_tuple rev_tuple = entry->tuple;
  	struct mlx5_ct_counter *shared_counter;
  	struct mlx5_ct_entry *rev_entry;
-	__be16 tmp_port;
  
  	/* get the reversed tuple */
-	tmp_port = rev_tuple.port.src;
-	rev_tuple.port.src = rev_tuple.port.dst;
-	rev_tuple.port.dst = tmp_port;
+	swap(rev_tuple.port.src, rev_tuple.port.dst);
  
  	if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
  		__be32 tmp_addr = rev_tuple.ip.src_v4;

just small comment on the title.
missing a space in the commit title after the colon.
I also think the prefix should be "net/mlx5e: CT, ..."

Reviewed-by: Roi Dayan <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help