[PATCH] net/mlx5:using swap() instead of tmp variable

Subsystems: mellanox mlx5 core vpi driver, networking drivers, the rest

STALE1727d

4 messages, 3 authors, 2021-11-16 · open the first message on its own page

[PATCH] net/mlx5:using swap() instead of tmp variable

From: Yihao Han <hidden>
Date: 2021-11-03 06:21:35 

swap() was used instead of the tmp variable to swap values

Signed-off-by: Yihao Han <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index 740cd6f088b8..d4b4f32603f2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
 	struct mlx5_ct_tuple rev_tuple = entry->tuple;
 	struct mlx5_ct_counter *shared_counter;
 	struct mlx5_ct_entry *rev_entry;
-	__be16 tmp_port;
 
 	/* get the reversed tuple */
-	tmp_port = rev_tuple.port.src;
-	rev_tuple.port.src = rev_tuple.port.dst;
-	rev_tuple.port.dst = tmp_port;
+	swap(rev_tuple.port.src, rev_tuple.port.dst);
 
 	if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
 		__be32 tmp_addr = rev_tuple.ip.src_v4;
-- 
2.17.1

Re: [PATCH] net/mlx5:using swap() instead of tmp variable

From: Roi Dayan <hidden>
Date: 2021-11-03 06:57:30 


On 2021-11-03 8:21 AM, Yihao Han wrote:
quoted hunk
swap() was used instead of the tmp variable to swap values

Signed-off-by: Yihao Han <redacted>
---
  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index 740cd6f088b8..d4b4f32603f2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
  	struct mlx5_ct_tuple rev_tuple = entry->tuple;
  	struct mlx5_ct_counter *shared_counter;
  	struct mlx5_ct_entry *rev_entry;
-	__be16 tmp_port;
  
  	/* get the reversed tuple */
-	tmp_port = rev_tuple.port.src;
-	rev_tuple.port.src = rev_tuple.port.dst;
-	rev_tuple.port.dst = tmp_port;
+	swap(rev_tuple.port.src, rev_tuple.port.dst);
  
  	if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
  		__be32 tmp_addr = rev_tuple.ip.src_v4;

just small comment on the title.
missing a space in the commit title after the colon.
I also think the prefix should be "net/mlx5e: CT, ..."

Reviewed-by: Roi Dayan <redacted>

Re: [PATCH] net/mlx5:using swap() instead of tmp variable

From: Saeed Mahameed <saeedm@nvidia.com>
Date: 2021-11-03 19:33:52 

On Wed, 2021-11-03 at 08:57 +0200, Roi Dayan wrote:

On 2021-11-03 8:21 AM, Yihao Han wrote:
quoted
swap() was used instead of the tmp variable to swap values

Signed-off-by: Yihao Han <redacted>
---
  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index 740cd6f088b8..d4b4f32603f2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct
mlx5_tc_ct_priv *ct_priv,
        struct mlx5_ct_tuple rev_tuple = entry->tuple;
        struct mlx5_ct_counter *shared_counter;
        struct mlx5_ct_entry *rev_entry;
-       __be16 tmp_port;
  
        /* get the reversed tuple */
-       tmp_port = rev_tuple.port.src;
-       rev_tuple.port.src = rev_tuple.port.dst;
-       rev_tuple.port.dst = tmp_port;
+       swap(rev_tuple.port.src, rev_tuple.port.dst);
  
        if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
                __be32 tmp_addr = rev_tuple.ip.src_v4;

just small comment on the title.
missing a space in the commit title after the colon.
I also think the prefix should be "net/mlx5e: CT, ..."

Reviewed-by: Roi Dayan <redacted>
Fixed-up the commit message and applied to net-next-mlx5

Re: [PATCH] net/mlx5:using swap() instead of tmp variable

From: Saeed Mahameed <saeedm@nvidia.com>
Date: 2021-11-16 20:55:30 

On Wed, 2021-11-03 at 08:57 +0200, Roi Dayan wrote:

On 2021-11-03 8:21 AM, Yihao Han wrote:
quoted
swap() was used instead of the tmp variable to swap values

Signed-off-by: Yihao Han <redacted>
---
  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index 740cd6f088b8..d4b4f32603f2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct
mlx5_tc_ct_priv *ct_priv,
        struct mlx5_ct_tuple rev_tuple = entry->tuple;
        struct mlx5_ct_counter *shared_counter;
        struct mlx5_ct_entry *rev_entry;
-       __be16 tmp_port;
  
        /* get the reversed tuple */
-       tmp_port = rev_tuple.port.src;
-       rev_tuple.port.src = rev_tuple.port.dst;
-       rev_tuple.port.dst = tmp_port;
+       swap(rev_tuple.port.src, rev_tuple.port.dst);
  
        if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
                __be32 tmp_addr = rev_tuple.ip.src_v4;

just small comment on the title.
missing a space in the commit title after the colon.
I also think the prefix should be "net/mlx5e: CT, ..."

Reviewed-by: Roi Dayan <redacted>
Fixed up and applied to net-next-mlx5.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help