Re: [PATCH v7 2/2] Bluetooth: aosp: Support AOSP Bluetooth Quality Report

Hi Joseph,

This patch adds the support of the AOSP Bluetooth Quality Report
(BQR) events.

Multiple vendors have supported the AOSP Bluetooth Quality Report.
When a Bluetooth controller supports the capability, it can enable
the aosp capability through hci_set_aosp_capable. Then hci_core will
set up the hdev->aosp_set_quality_report callback through aosp_do_open
if the controller responds to support the quality report capability.

Note that Intel also supports a distinct telemetry quality report
specification. Intel sets up the hdev->set_quality_report callback
in the btusb driver module.

Reviewed-by: Miao-chen Chou <redacted>
Signed-off-by: Joseph Hwang <redacted>

---

Changes in v7:
- Remove the unnecessary debug print.

Changes in v6:
- Use the decimal version instead of hexadecimal version to be
 consistent with the AOSP specification.
- Move the code of checking the bluetooth_quality_report_support field
 to the previous patch.

Changes in v5:
- Fix the patch per
 [RFC PATCH] Bluetooth: Add framework for AOSP quality report setting
- Declare aosp_set_quality_report.
- Use aosp_do_open() to set hdev->aosp_set_quality_report.
- Add aosp_has_quality_report().
- In mgmt, use hdev->aosp_set_quality_report and
 hdev->set_quality_report separately.

Changes in v4:
- Move the AOSP BQR support from the driver level to net/bluetooth/aosp.
- Fix the drivers to use hci_set_aosp_capable to enable aosp.
- Add Mediatek to support the capability too.

Changes in v3:
- Fix the auto build test ERROR
 "undefined symbol: btandroid_set_quality_report" that occurred
 with some kernel configs.
- Note that the mgmt-tester "Read Exp Feature - Success" failed.
 But on my test device, the same test passed. Please kindly let me
 know what may be going wrong. These patches do not actually
 modify read/set experimental features.
- As to CheckPatch failed. No need to modify the MAINTAINERS file.
 Thanks.

Changes in v2:
- Fix the titles of patches 2/3 and 3/3 and reduce their lengths.

net/bluetooth/aosp.c | 87 ++++++++++++++++++++++++++++++++++++++++++++
net/bluetooth/aosp.h | 13 +++++++
net/bluetooth/mgmt.c | 17 ++++++---
3 files changed, 112 insertions(+), 5 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel