On Mon, 29 Nov 2021 23:06:38 +0000
"Russell King (Oracle)" [off-list ref] wrote:

On Mon, Nov 29, 2021 at 08:58:20PM +0100, Marek Behún wrote:

quoted

+static int mv88e6393x_serdes_power_lane(struct mv88e6xxx_chip *chip, int lane,
+					bool on)
+{
+	u16 reg;
+	int err;
+
+	err = mv88e6390_serdes_read(chip, lane, MDIO_MMD_PHYXS,
+				    MV88E6393X_SERDES_CTRL1, &reg);
+	if (err)
+		return err;
+
+	if (on)
+		reg &= !(MV88E6393X_SERDES_CTRL1_TX_PDOWN |
+			 MV88E6393X_SERDES_CTRL1_RX_PDOWN);  

Are you sure this is correct? Don't you want that to be ~(...) ?

/o\ How did I not notice this? Thanks.