Re: [PATCH net v2 1/3] net: dsa: realtek-smi: don't log an error on EPROBE_DEFER
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-11-29 20:22:53
On 29.11.2021 11:30, Alvin Šipraga wrote:
quoted hunk ↗ jump to hunk
From: Alvin Šipraga <alsi@bang-olufsen.dk> Probe deferral is not an error, so don't log this as an error: [0.590156] realtek-smi ethernet-switch: unable to register switch ret = -517 Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk> --- drivers/net/dsa/realtek-smi-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v2: use dev_err_probe() instead of manually checking retdiff --git a/drivers/net/dsa/realtek-smi-core.c b/drivers/net/dsa/realtek-smi-core.c index c66ebd0ee217..aae46ada8d83 100644 --- a/drivers/net/dsa/realtek-smi-core.c +++ b/drivers/net/dsa/realtek-smi-core.c@@ -456,7 +456,7 @@ static int realtek_smi_probe(struct platform_device *pdev) smi->ds->ops = var->ds_ops; ret = dsa_register_switch(smi->ds); if (ret) { - dev_err(dev, "unable to register switch ret = %d\n", ret); + dev_err_probe(dev, ret, "unable to register switch\n"); return ret;
Nit, following would have been simpler: if (ret) return dev_err_probe(dev, ret, "unable to register switch\n");
} return 0;