Thread (17 messages) flat view 17 messages, 4 authors, 2021-12-03

Re: [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-11-26 03:03:04

On Thu, 25 Nov 2021 23:45:21 +0000 Vladimir Oltean wrote:
On Fri, Nov 26, 2021 at 01:21:14AM +0200, Vladimir Oltean wrote:
quoted
Po Liu reported recently that timestamping PTP over IPv4 is broken using
the felix driver on NXP LS1028A. This has been known for a while, of
course, since it has always been broken. The reason is because IP PTP
packets are currently treated as unknown IP multicast, which is not
flooded to the CPU port in the ocelot driver design, so packets don't
reach the ptp4l program.

The series solves the problem by installing packet traps per port when
the timestamping ioctl is called, depending on the RX filter selected
(L2, L4 or both).
I don't know why I targeted these patches to "net-next". Habit I guess.
Nonetheless, they apply equally well to "net", can they be considered
for merging there without me resending?
Only patch 1 looks like a fix, tho? Patch 4 seems to fall into 
the "this never worked and doesn't cause a crash" category.

I'm hoping to send a PR tomorrow, so if you resend quickly it 
will be in net-next soon.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help