Thread (3 messages) 3 messages, 3 authors, 2021-11-25

Re: [PATCH net] lan743x: fix deadlock in lan743x_phy_link_status_change()

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-11-24 15:31:00

On Wed, Nov 24, 2021 at 08:16:25AM +0100, Heiner Kallweit wrote:
Usage of phy_ethtool_get_link_ksettings() in the link status change
handler isn't needed, and in combination with the referenced change
it results in a deadlock. Simply remove the call and replace it with
direct access to phydev->speed. The duplex argument of 
lan743x_phy_update_flowcontrol() isn't used and can be removed.

Fixes: c10a485c3de5 ("phy: phy_ethtool_ksettings_get: Lock the phy for consistency")
Reported-by: Alessandro B Maurici <redacted>
Tested-by: Alessandro B Maurici <redacted>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Thanks Heiner

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help