Thread (11 messages) flat view 11 messages, 4 authors, 2021-11-23

Re: [PATCH] phy: fix possible double lock calling link changed handler

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-11-23 14:11:33

Seeing the following code snippet in lan743x_phy_link_status_change()
I wonder why it doesn't use phydev->speed and phydev->duplex directly.
The current code seems to include unneeded overhead.
Yes, that is the change i would make. When adding the extra locks i
missed that a driver was doing something like this. I will check all
other callers to see if they are using it in odd contexts.

     Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help