Thread (3 messages) flat view 3 messages, 3 authors, 2021-11-23

Re: [PATCH net] r8169: fix incorrect mac address assignment

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-11-23 02:35:16

On Mon, 22 Nov 2021 22:35:33 +0100 Heiner Kallweit wrote:
The original changes brakes MAC address assignment on older chip
versions (see bug report [0]), and it brakes random MAC assignment.

is_valid_ether_addr() requires that its argument is word-aligned.
Add the missing alignment to array mac_addr.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=215087

Fixes: 1c5d09d58748 ("ethernet: r8169: use eth_hw_addr_set()")
Reported-by: Richard Herbert <redacted>
Tested-by: Richard Herbert <redacted>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help