Re: [PATCH net v11 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver
From: Joe Perches <joe@perches.com>
Date: 2021-11-18 19:18:51
Also in:
linux-m68k
On Mon, 2021-11-15 at 12:40 +1300, Michael Schmitz wrote:
Add module parameter, IO mode autoprobe and PCMCIA reset code required to support 100 Mbit PCMCIA ethernet cards on Amiga.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/8390/apne.c b/drivers/net/ethernet/8390/apne.c
[]
quoted hunk ↗ jump to hunk
@@ -119,6 +119,48 @@ static u32 apne_msg_enable;
[]
+ cftuple_len = pcmcia_copy_tuple(CISTPL_CFTABLE_ENTRY, cftuple, 256); + if (cftuple_len < 3) + return 0; +#ifdef DEBUG + else + print_hex_dump(KERN_WARNING, "cftable: ", DUMP_PREFIX_NONE, 8, + sizeof(char), cftuple, cftuple_len, false); +#endif
Why KERN_WARNING and why not use print_hex_dump_debug without the #ifdef []
+#ifdef DEBUG
+ pr_info("IO flags: %x\n", cftable_entry.io.flags);pr_debug ?