Re: [DISCUSS] Bond arp monitor not works with veth due to flag NETIF_F_LLTX.
From: Hangbin Liu <hidden>
Date: 2021-11-18 10:18:48
On Wed, Nov 17, 2021 at 07:34:40PM -0800, Eric Dumazet wrote:
Removing LLTX will have performance impact.
Yes, I also think so.
quoted hunk ↗ jump to hunk
Updating ->trans_start at most once per jiffy should be ok. Here is a patch against net-next@@ -4626,7 +4620,7 @@ static inline netdev_tx_tnetdev_start_xmit(struct sk_buff *skb, struct net_devi rc = __netdev_start_xmit(ops, skb, dev, more); if (rc == NETDEV_TX_OK) - txq_trans_update(txq); + txq_trans_cond_update(txq); return rc; }
Awesome. This should resolve the veth's trans_start issue. Where is the patch? I only find out the following one but could not find the fix in netdev_start_xmit() https://patchwork.kernel.org/project/netdevbpf/patch/20211117032924.1740327-3-eric.dumazet@gmail.com/ Thanks Hangbin