RE: [PATCH net-next iproute2] vdpa: Remove duplicate vdpa UAPI header file
From: Parav Pandit <hidden>
Date: 2021-11-18 04:21:55
Hi David, Stephen,
From: Parav Pandit <redacted> Sent: Saturday, November 6, 2021 12:12 PM vdpa header file is already present in the tree at vdpa/include/uapi/linux/vdpa.h and used by vdpa/vdpa.c. As we discussed in thread [1] vdpa header comes from a different tree, similar to rdma subsystem. Hence remove the duplicate vdpa UAPI header file.
[..]
Fixes: b5a6ed9cc9fc ("uapi: add missing virtio related headers")
Signed-off-by: Parav Pandit <redacted>Can you please review this fix? I need to submit further extensions to vdpa tool that needs header update; and above fix is necessary.
quoted hunk ↗ jump to hunk
--- include/uapi/linux/vdpa.h | 40 --------------------------------------- 1 file changed, 40 deletions(-) delete mode 100644 include/uapi/linux/vdpa.hdiff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h deleted filemode 100644 index 37ae26b6..00000000--- a/include/uapi/linux/vdpa.h +++ /dev/null@@ -1,40 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */ -/* - * vdpa device management interface - * Copyright (c) 2020 Mellanox Technologies Ltd. All rights reserved. - */ - -#ifndef _LINUX_VDPA_H_ -#define _LINUX_VDPA_H_ - -#define VDPA_GENL_NAME "vdpa" -#define VDPA_GENL_VERSION 0x1 - -enum vdpa_command { - VDPA_CMD_UNSPEC, - VDPA_CMD_MGMTDEV_NEW, - VDPA_CMD_MGMTDEV_GET, /* can dump */ - VDPA_CMD_DEV_NEW, - VDPA_CMD_DEV_DEL, - VDPA_CMD_DEV_GET, /* can dump */ -}; - -enum vdpa_attr { - VDPA_ATTR_UNSPEC, - - /* bus name (optional) + dev name together make the parent devicehandle */ - VDPA_ATTR_MGMTDEV_BUS_NAME, /* string */ - VDPA_ATTR_MGMTDEV_DEV_NAME, /* string */ - VDPA_ATTR_MGMTDEV_SUPPORTED_CLASSES, /* u64 */ - - VDPA_ATTR_DEV_NAME, /* string */ - VDPA_ATTR_DEV_ID, /* u32 */ - VDPA_ATTR_DEV_VENDOR_ID, /* u32 */ - VDPA_ATTR_DEV_MAX_VQS, /* u32 */ - VDPA_ATTR_DEV_MAX_VQ_SIZE, /* u16 */ - - /* new attributes must be added above here */ - VDPA_ATTR_MAX, -}; - -#endif -- 2.26.2