Re: [PATCH net-next v5 3/3] tsnep: Add TSN endpoint Ethernet MAC driver
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-11-16 23:41:10
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-11-16 23:41:10
quoted
quoted
diff --git a/drivers/net/ethernet/engleder/tsnep_test.c b/drivers/net/ethernet/engleder/tsnep_test.cYou have quite a lot of code in this file. Could it either be 1) A loadable module which extends the base driver? 2) A build time configuration option? What percentage of the overall driver binary does this test code take up?Driver is 484kB with test code and 396kB without. So test code is roughly 20% currently. In my opinion a configuration option makes more sense,
Yes, that is good, please add one.
Andrew