RE: [PATCH v3 net-next 2/6] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status
From: Machnikowski, Maciej <hidden>
Date: 2021-11-16 14:41:00
Also in:
intel-wired-lan, linux-kselftest
-----Original Message----- From: Florian Westphal <fw@strlen.de> Sent: Thursday, November 11, 2021 5:23 PM To: Sabrina Dubroca <sd@queasysnail.net> Subject: Re: [PATCH v3 net-next 2/6] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status Sabrina Dubroca [off-list ref] wrote:quoted
Hello Maciej, 2021-11-10, 12:44:44 +0100, Maciej Machnikowski wrote:quoted
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index 5888492a5257..1d8662afd6bd 100644 --- a/include/uapi/linux/rtnetlink.h +++ b/include/uapi/linux/rtnetlink.h@@ -185,6 +185,9 @@ enum { RTM_GETNEXTHOPBUCKET, #define RTM_GETNEXTHOPBUCKET RTM_GETNEXTHOPBUCKET + RTM_GETEECSTATE = 124, +#define RTM_GETEECSTATE RTM_GETEECSTATEI'm not sure about this. All the other RTM_GETxxx are such that RTM_GETxxx % 4 == 2. Following the current pattern, 124 should be reserved for RTM_NEWxxx, and RTM_GETEECSTATE would be 126.More importantly, why is this added to rtnetlink (routing sockets)? It appears to be unrelated? Looks like this should be in ethtool (it has netlink api nowadays) or devlink.
We identified it as a generic place in previous RFCs. Ethtool calls are not available in non-ethernet packet networks and the concept of that functionality is - any packet network can implement it - SONET, GPON or even wireless.