Re: [RFC 0/5] devlink: add an explicit locking API

From
Leon Romanovsky <leon@kernel.org>
Date
2021-11-02 17:50:48
Reply to
Jakub Kicinski, 2021-11-02
On Tue, Nov 02, 2021 at 08:16:06AM -0700, Jakub Kicinski wrote:
On Tue, 2 Nov 2021 09:44:17 +0200 Leon Romanovsky wrote:
quoted
On Mon, Nov 01, 2021 at 01:04:03PM -0700, Edwin Peer wrote:
quoted
On Sun, Oct 31, 2021 at 12:23 AM Leon Romanovsky [off-list ref] wrote:
  
quoted
The average driver author doesn't know locking well and won't be able to
use devlink reference counting correctly.  
I think this problem largely only exists to the extent that locking
and lifecycle requirements are poorly documented. :P  
I'm talking about general locking concepts that are perfectly documented
and still people do crazy things with it. :)
Yet you seem to be pushing for drivers to implement their own locking.
It wasn't me who suggested to expose devlink internal locks and
reference counting to the drivers. In my implementation, drivers
don't need to manage devlink at all and we will be able internally
understand if lock is needed or not.

At least in theory, working to make it true.

Thanks
Thread (23 messages) 23 messages, 4 authors, last reply 2021-11-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help