Re: [PATCH net 4/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2021-11-01 23:02:55
Also in:
linux-kselftest
On Mon, Nov 1, 2021 at 12:06 AM Hangbin Liu [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When generating the selftests to another folder, the toeplitz.sh and toeplitz_client.sh are missing as they are not in Makefile, e.g. make -C tools/testing/selftests/ install \ TARGETS="net" INSTALL_PATH=/tmp/kselftests Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test") Signed-off-by: Hangbin Liu <redacted> --- tools/testing/selftests/net/Makefile | 2 ++ 1 file changed, 2 insertions(+)diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index 8a6264da5276..514bbed80e68 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile@@ -31,7 +31,9 @@ TEST_PROGS += gre_gso.sh TEST_PROGS += srv6_end_dt46_l3vpn_test.sh TEST_PROGS += srv6_end_dt4_l3vpn_test.sh TEST_PROGS += srv6_end_dt6_l3vpn_test.sh +TEST_PROGS += toeplitz.sh TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh +TEST_PROGS_EXTENDED += toeplitz_client.sh
Thanks for adding the files. They are indeed missing. But they are not intended to be run from kselftests, as this tests nic hardware features. So both files should be under TEST_PROGS_EXTENDED?