[PATCH net-next] netdevsim: fix uninit value in nsim_drv_configure_vfs()
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-11-01 22:18:47
Subsystem:
netdevsim, networking drivers, the rest · Maintainers:
Jakub Kicinski, Andrew Lunn, "David S. Miller", Eric Dumazet, Paolo Abeni, Linus Torvalds
Build bot points out that I missed initializing ret
after refactoring.
Reported-by: kernel test robot <redacted>
Fixes: 1c401078bcf3 ("netdevsim: move details of vf config to dev")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/netdevsim/dev.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index 5db40d713d2a..54345c096a16 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c@@ -1723,13 +1723,11 @@ int nsim_drv_configure_vfs(struct nsim_bus_dev *nsim_bus_dev, unsigned int num_vfs) { struct nsim_dev *nsim_dev = dev_get_drvdata(&nsim_bus_dev->dev); - int ret; + int ret = 0; mutex_lock(&nsim_dev->vfs_lock); - if (nsim_bus_dev->num_vfs == num_vfs) { - ret = 0; + if (nsim_bus_dev->num_vfs == num_vfs) goto exit_unlock; - } if (nsim_bus_dev->num_vfs && num_vfs) { ret = -EBUSY; goto exit_unlock;
--
2.31.1