Re: [PATCH net-next v3 3/3] tsnep: Add TSN endpoint Ethernet MAC driver
From: Gerhard Engleder <hidden>
Date: 2021-11-01 20:29:53
From: Gerhard Engleder <hidden>
Date: 2021-11-01 20:29:53
quoted
About endian: I have not considered endian so far, as this driver is used only for x86 and arm64. Is that ok?In most cases, there is little you need to do, so long as you use the correct methods to access the bus. PCI registers are always little endian for example, so easy to handle. Memory mapped structures are where you need to be careful, your receive and transmit descriptors. You need to use the correct __le32 or __be32 annotation, and then sparse will warn you if you access them without the needed conversion.
Thanks! Now I get those warnings. I'll fix them. Gerhard