On 2021/10/31 2:05, Andrew Lunn wrote:

On Sat, Oct 30, 2021 at 09:10:01PM +0800, Guangbin Huang wrote:

quoted

From: Hao Chen <redacted>

The way to set tx spare buf via module parameter is not such
convenient as the way to set it via ethtool.

So,remove the way to set tx spare buf via module parameter.

Signed-off-by: Hao Chen <redacted>
Signed-off-by: Guangbin Huang <redacted>
---
  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 076631d7727d..032547a2ad2f 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

@@ -53,10 +53,6 @@ static int debug = -1;
  module_param(debug, int, 0);
  MODULE_PARM_DESC(debug, " Network interface message level setting");
  
-static unsigned int tx_spare_buf_size;
-module_param(tx_spare_buf_size, uint, 0400);
-MODULE_PARM_DESC(tx_spare_buf_size, "Size used to allocate tx spare buffer");
-

This might be considered ABI. By removing it, are you breaking users
setup?

	Andrew
.

Yes, patch 1/6 and 2/6 add support for ethtool to set tx spare(copybreak) buf size,
so remove the way to set it by module parameter.