Re: [PATCH net-next v2 13/14] ravb: Update EMAC configuration mode comment
From: Sergei Shtylyov <hidden>
Date: 2021-10-10 09:27:52
Also in:
linux-renesas-soc
On 10.10.2021 10:29, Biju Das wrote:
quoted hunk ↗ jump to hunk
Update EMAC configuration mode comment from "PAUSE prohibition" to "EMAC Mode: PAUSE prohibition; Duplex; TX; RX; CRC Pass Through; Promiscuous". Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Suggested-by: Sergey Shtylyov <redacted> --- v1->v2: * No change V1: * New patch. --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 9a770a05c017..b78aca235c37 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c@@ -519,7 +519,7 @@ static void ravb_emac_init_gbeth(struct net_device *ndev) /* Receive frame limit set register */ ravb_write(ndev, GBETH_RX_BUFF_MAX + ETH_FCS_LEN, RFLR); - /* PAUSE prohibition */ + /* EMAC Mode: PAUSE prohibition; Duplex; TX; RX; CRC Pass Through; Promiscuous */
Promiscuous mode, really? Why?!
ravb_write(ndev, ECMR_ZPF | ((priv->duplex > 0) ? ECMR_DM : 0) | ECMR_TE | ECMR_RE | ECMR_RCPT | ECMR_TXF | ECMR_RXF | ECMR_PRM, ECMR);
MBR, Sergey