Re: [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random() where appropriate

From
Linus Walleij <hidden>
Date
2021-10-13 23:52:50
Also in
linux-arm-kernel
Reply to
Jakub Kicinski, 2021-10-13
On Wed, Oct 13, 2021 at 10:44 PM Jakub Kicinski [off-list ref] wrote:
Number of drivers use eth_random_addr(netdev->dev_addr)
thus writing to netdev->dev_addr directly, and not setting
the address type. Switch them to eth_hw_addr_random().

  @@
  expression netdev;
  @@
  - eth_random_addr(netdev->dev_addr);
  + eth_hw_addr_random(netdev);

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Oh this is better.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Thread (15 messages) 15 messages, 6 authors, last reply 2021-10-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help