On 16:02 01.10.21, Jakub Kicinski wrote:

On Wed, 29 Sep 2021 23:02:35 +0200 Heiko Stübner wrote:

quoted

Am Mittwoch, 29. September 2021, 15:50:49 CEST schrieb Punit Agrawal:

quoted

Commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
while getting rid of a runtime PM warning ended up breaking ethernet
on rk3399 based devices. By dropping an extra reference to the device,
the commit ends up enabling suspend / resume of the ethernet device -
which appears to be broken.

While the issue with runtime pm is being investigated, partially
revert commit 2d26f6e39afb to restore the network on rk3399.

Fixes: 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
Suggested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Punit Agrawal <redacted>
Cc: Michael Riesch <redacted>  

On a rk3399-puma which has the described issue,
Tested-by: Heiko Stuebner <heiko@sntech.de>

Applied, thanks!

This also fixed the issue on a RockPi4.

Will any of you submit this to the stable kernels (as this broke within
3.13 for me) or shall I do that?