Thread (8 messages) 8 messages, 3 authors, 2021-10-29

RE: [PATHC bpf v5 3/3] selftests, bpf: Add one test for sockmap with strparser

From: John Fastabend <john.fastabend@gmail.com>
Date: 2021-10-22 15:31:20
Also in: bpf

Liu Jian wrote:
Add the test to check sockmap with strparser is working well.

Signed-off-by: Liu Jian <redacted>
---
 tools/testing/selftests/bpf/test_sockmap.c | 33 ++++++++++++++++++++--
 1 file changed, 30 insertions(+), 3 deletions(-)
Hi Liu,

This is a good test, but we should also add one with a parser returning
a value that is not skb->len. This doesn't cover the case fixed in
patch 1/3 correct? For that we would need to modify the BPF prog
itself as well sockmap_parse_prog.c.

For this patch though,

Acked-by: John Fastabend <john.fastabend@gmail.com>

Then one more patch is all we need something to break up the skb from
the parser. We really need the test because its not something we
can easily test otherwise and I don't have any use cases that do this
so wouldn't catch it.

Thanks!
John
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help