Re: [PATCH bpf-next v2 0/3] libbpf: use func name when pinning programs with LIBBPF_STRICT_SEC_NAME
From: Andrii Nakryiko <hidden>
Date: 2021-10-20 18:14:28
Also in:
bpf
On Tue, Oct 12, 2021 at 9:15 AM Stanislav Fomichev [off-list ref] wrote:
Commit 15669e1dcd75 ("selftests/bpf: Normalize all the rest SEC() uses")
broke flow dissector tests. With the strict section names, bpftool isn't
able to pin all programs of the objects (all section names are the
same now). To bring it back to life let's do the following:
- teach libbpf to pin by func name with LIBBPF_STRICT_SEC_NAME
- enable strict mode in bpftool (breaking cli change)
- fix custom flow_dissector loader to use strict mode
- fix flow_dissector tests to use new pin names (func vs sec)
v2:
- add github issue (Andrii Nakryiko)
- remove sec_name from bpf_program.pin_name comment (Andrii Nakryiko)
- clarify program pinning in LIBBPF_STRICT_SEC_NAME (Andrii Nakryiko)I could not find this, can you please point me to where this is clarified/explained in your patches?
- add cover letter (Andrii Nakryiko)
Stanislav Fomichev (3):
libbpf: use func name when pinning programs with
LIBBPF_STRICT_SEC_NAME
bpftool: don't append / to the progtype
selftests/bpf: fix flow dissector tests
tools/bpf/bpftool/main.c | 4 ++++
tools/bpf/bpftool/prog.c | 15 +--------------
tools/lib/bpf/libbpf.c | 10 ++++++++--
.../selftests/bpf/flow_dissector_load.c | 18 +++++++++++-------
.../selftests/bpf/flow_dissector_load.h | 10 ++--------
.../selftests/bpf/test_flow_dissector.sh | 10 +++++-----
6 files changed, 31 insertions(+), 36 deletions(-)
--
2.33.0.882.g93a45727a2-goog