Thread (2 messages) flat view 2 messages, 2 authors, 2021-10-06

Re: [PATCH bpf-next] bpf: use $(pound) instead of \# in Makefiles

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-06 16:30:08
Also in: bpf

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Wed,  6 Oct 2021 12:10:49 +0100 you wrote:
Recent-ish versions of make do no longer consider number signs ("#") as
comment symbols when they are inserted inside of a macro reference or in
a function invocation. In such cases, the symbols should not be escaped.

There are a few occurrences of "\#" in libbpf's and samples' Makefiles.
In the former, the backslash is harmless, because grep associates no
particular meaning to the escaped symbol and reads it as a regular "#".
In samples' Makefile, recent versions of make will pass the backslash
down to the compiler, making the probe fail all the time and resulting
in the display of a warning about "make headers_install" being required,
even after headers have been installed.

[...]
Here is the summary with links:
  - [bpf-next] bpf: use $(pound) instead of \# in Makefiles
    https://git.kernel.org/bpf/bpf-next/c/bf2819e0b10f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help