Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building

[PATCH bpf-next v2 0/9] install libbpf headers when using the library · Quentin Monnet <hidden> · 2021-10-01
[PATCH bpf-next v2 1/9] tools: bpftool: remove unused includes to <bpf/bpf_gen_internal.h> · Quentin Monnet <hidden> · 2021-10-01
[PATCH bpf-next v2 2/9] tools: bpftool: install libbpf headers instead of including the dir · Quentin Monnet <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 2/9] tools: bpftool: install libbpf headers instead of including the dir · Andrii Nakryiko <hidden> · 2021-10-01
[PATCH bpf-next v2 3/9] tools: resolve_btfids: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 3/9] tools: resolve_btfids: install libbpf headers when building · Andrii Nakryiko <hidden> · 2021-10-01
[PATCH bpf-next v2 4/9] tools: runqslower: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-01
[PATCH bpf-next v2 5/9] bpf: preload: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-01
[PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Andrii Nakryiko <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-02
Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-02
Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Andrii Nakryiko <hidden> · 2021-10-04
Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-04
Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-05
Re: [PATCH bpf-next v2 6/9] bpf: iterators: install libbpf headers when building · Andrii Nakryiko <hidden> · 2021-10-06
[PATCH bpf-next v2 8/9] samples/bpf: update .gitignore · Quentin Monnet <hidden> · 2021-10-01
[PATCH bpf-next v2 7/9] samples/bpf: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 7/9] samples/bpf: install libbpf headers when building · Andrii Nakryiko <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 7/9] samples/bpf: install libbpf headers when building · Quentin Monnet <hidden> · 2021-10-02
[PATCH bpf-next v2 9/9] selftests/bpf: better clean up for runqslower in test_bpftool_build.sh · Quentin Monnet <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 0/9] install libbpf headers when using the library · Andrii Nakryiko <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 0/9] install libbpf headers when using the library · Andrii Nakryiko <hidden> · 2021-10-01
Re: [PATCH bpf-next v2 0/9] install libbpf headers when using the library · Quentin Monnet <hidden> · 2021-10-02
Re: [PATCH bpf-next v2 0/9] install libbpf headers when using the library · Quentin Monnet <hidden> · 2021-10-03

From: Quentin Monnet <hidden>
Date: 2021-10-02 20:27:30
Also in: bpf

On Sat, 2 Oct 2021 at 00:20, Andrii Nakryiko [off-list ref] wrote:

On Fri, Oct 1, 2021 at 4:09 AM Quentin Monnet [off-list ref] wrote:

quoted

API headers from libbpf should not be accessed directly from the
library's source directory. Instead, they should be exported with "make
install_headers". Let's make sure that bpf/preload/iterators/Makefile
installs the headers properly when building.

quoted

-$(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile) | $(OUTPUT)
+$(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile)            \
+          | $(LIBBPF_OUTPUT) $(LIBBPF_INCLUDE)

Would it make sense for libbpf's Makefile to create include and output
directories on its own? We wouldn't need to have these order-only
dependencies everywhere, right?

Good point, I'll have a look at it.
Quentin

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help