Re: [PATCH bpf-next v2 1/3] libfs: support RENAME_EXCHANGE in simple_rename()

[PATCH bpf-next v2 0/3] Support RENAME_EXCHANGE on bpffs · Lorenz Bauer <hidden> · 2021-10-21
[PATCH bpf-next v2 1/3] libfs: support RENAME_EXCHANGE in simple_rename() · Lorenz Bauer <hidden> · 2021-10-21
Re: [PATCH bpf-next v2 1/3] libfs: support RENAME_EXCHANGE in simple_rename() · Alexei Starovoitov <hidden> · 2021-10-22
Re: [PATCH bpf-next v2 1/3] libfs: support RENAME_EXCHANGE in simple_rename() · Daniel Borkmann <daniel@iogearbox.net> · 2021-10-27
Re: [PATCH bpf-next v2 1/3] libfs: support RENAME_EXCHANGE in simple_rename() · Miklos Szeredi <hidden> · 2021-10-28
Re: [PATCH bpf-next v2 1/3] libfs: support RENAME_EXCHANGE in simple_rename() · Lorenz Bauer <hidden> · 2021-10-28
[PATCH bpf-next v2 3/3] selftests: bpf: test RENAME_EXCHANGE and RENAME_NOREPLACE on bpffs · Lorenz Bauer <hidden> · 2021-10-21
[PATCH bpf-next v2 2/3] selftests: bpf: convert test_bpffs to ASSERT macros · Lorenz Bauer <hidden> · 2021-10-21

From: Lorenz Bauer <hidden>
Date: 2021-10-28 09:49:35
Also in: bpf, linux-fsdevel, lkml

On Thu, 28 Oct 2021 at 09:43, Miklos Szeredi [off-list ref] wrote:

This is not sufficient.   RENAME_EXCHANGE can swap a dir and a
non-dir, in which case the parent nlink counters need to be fixed up.

See shmem_exchange().   My suggestion is to move that function to
libfs.c:simple_rename_exchange().

Thanks for the pointer, I sent a v3.

Lorenz

-- 
Lorenz Bauer  |  Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help