Thread (16 messages) 16 messages, 4 authors, 2021-11-01

RE: [PATCH net-next 1/4] net: mana: Fix the netdev_err()'s vPort argument in mana_init_port()

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2021-10-30 15:30:47
Also in: linux-hyperv, lkml

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Dexuan Cui <decui@microsoft.com>
Sent: Friday, October 29, 2021 8:54 PM
To: davem@davemloft.net; kuba@kernel.org; gustavoars@kernel.org; Haiyang
Zhang [off-list ref]; netdev@vger.kernel.org
Cc: KY Srinivasan <kys@microsoft.com>; stephen@networkplumber.org;
wei.liu@kernel.org; linux-kernel@vger.kernel.org; linux-
hyperv@vger.kernel.org; Shachar Raindel [off-list ref]; Paul
Rosswurm [off-list ref]; olaf@aepfle.de; vkuznets
[off-list ref]; Dexuan Cui [off-list ref]
Subject: [PATCH net-next 1/4] net: mana: Fix the netdev_err()'s vPort
argument in mana_init_port()

Use the correct port index rather than 0.

Signed-off-by: Dexuan Cui <decui@microsoft.com>
---
 drivers/net/ethernet/microsoft/mana/mana_en.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c
b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 1417d1e72b7b..4ff5a1fc506f 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -1599,7 +1599,8 @@ static int mana_init_port(struct net_device *ndev)
 	err = mana_query_vport_cfg(apc, port_idx, &max_txq, &max_rxq,
 				   &num_indirect_entries);
 	if (err) {
-		netdev_err(ndev, "Failed to query info for vPort 0\n");
+		netdev_err(ndev, "Failed to query info for vPort %d\n",
+			   port_idx);
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help