Thread (3 messages) flat view 3 messages, 3 authors, 2021-10-26

Re: [net-next v1] tcp: don't free a FIN sk_buff in tcp_remove_empty_skb()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-26 12:20:12
Also in: lkml

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller [off-list ref]:

On Mon, 25 Oct 2021 10:59:03 +1100 you wrote:
v1: Implement a more general statement as recommended by Eric Dumazet. The
sequence number will be advanced, so this check will fix the FIN case and
other cases.

A customer reported sockets stuck in the CLOSING state. A Vmcore revealed that
the write_queue was not empty as determined by tcp_write_queue_empty() but the
sk_buff containing the FIN flag had been freed and the socket was zombied in
that state. Corresponding pcaps show no FIN from the Linux kernel on the wire.

[...]
Here is the summary with links:
  - [net-next,v1] tcp: don't free a FIN sk_buff in tcp_remove_empty_skb()
    https://git.kernel.org/netdev/net-next/c/cf12e6f91246

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help