Thread (12 messages) 12 messages, 5 authors, 2021-10-26

Re: [syzbot] WARNING in batadv_nc_mesh_free

From: Pavel Skripkin <hidden>
Date: 2021-10-22 20:58:21
Also in: batman, lkml

On 10/22/21 23:57, Pavel Skripkin wrote:
On 10/22/21 23:20, syzbot wrote:
quoted
Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
general protection fault in batadv_nc_purge_paths

Oh, ok. Next clean up call in batadv_nc_mesh_free() caused GPF, since
fields are not initialized. Let's try to clean up one by one and do not
break dependencies.

Quite ugly one, but idea is correct, I guess

Also, make each *_init() call clean up all allocated stuff to not call
corresponding *_free() on error handling path, since it introduces
problems, as syzbot reported


Whooops.... Forgot to ask syzbot to test the patch

#syz test
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master




With regards,
Pavel Skripkin

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help