Thread (3 messages) flat view 3 messages, 3 authors, 2021-10-20

Re: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

From: Andrii Nakryiko <hidden>
Date: 2021-10-20 17:47:07
Also in: bpf, linux-kselftest, lkml

On Mon, Oct 18, 2021 at 9:07 AM John Fastabend [off-list ref] wrote:
Wan Jiabing wrote:
quoted
Fix following checkincludes.pl warning:
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.

Signed-off-by: Wan Jiabing <redacted>
---
Changelog:
v2:
- Fix the commit description.
---
The Subject is a bit unusual. Typically it would be something like,

 "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"
Also for selftests we use "selftests/bpf: " prefix (at least we
generally try, for consistency). Fixed up, applied to bpf-next.
Thanks.
For the actual patch though LGTM.

Acked-by: John Fastabend <john.fastabend@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help