Re: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

From
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Date
2021-10-20 05:46:14
Also in
bpf, linux-doc, linux-kselftest, lkml
Reply to
Alexei Starovoitov, 2021-10-19
Em Tue, 19 Oct 2021 15:31:38 -0700
Alexei Starovoitov [off-list ref] escreveu:
On Tue, Oct 19, 2021 at 2:35 AM Quentin Monnet [off-list ref] wrote:
quoted
2021-10-19 09:04 UTC+0100 ~ Mauro Carvalho Chehab
[off-list ref]  
quoted
The file name: Documentation/bpftool-cgroup.rst
should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.

Update its cross-reference accordingly.

Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/cover.1634630485.git.mchehab+huawei@kernel.org/ (local)

 tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
index be54b7335a76..617b8084c440 100755
--- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
+++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
@@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
     """
     An extractor for bpftool-cgroup.rst.
     """
-    filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
+    filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')

     def get_attach_types(self):
         return self.get_rst_list('ATTACH_TYPE')
 
No, this change is incorrect. We have discussed it several times before
[0][1]. Please drop this patch.  
+1
Sorry, left-over. I dropped two other patches, but forgot to also drop
this one.

Regards,
Mauro
Thread (7 messages) 7 messages, 4 authors, last reply 2021-10-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help