Thread (22 messages) 22 messages, 4 authors, 2021-10-18

Re: [PATCH v4 net-next 01/10] dt-bindings: net: dsa: dt bindings for microchip lan937x

From: Rob Herring <robh@kernel.org>
Date: 2021-10-18 18:00:54
Also in: linux-devicetree, lkml

On Thu, Oct 07, 2021 at 11:41:39PM +0200, Andrew Lunn wrote:
quoted
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    //Ethernet switch connected via spi to the host
+    ethernet {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fixed-link {
+        speed = <1000>;
+        full-duplex;
+      };
+    };
+
+    spi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      lan9374: switch@0 {
+        compatible = "microchip,lan9374";
+        reg = <0>;
+
+        spi-max-frequency = <44000000>;
+
+        ethernet-ports {
+          #address-cells = <1>;
+          #size-cells = <0>;
+          port@0 {
+            reg = <0>;
+            label = "lan1";
+            phy-mode = "internal";
+            phy-handle = <&t1phy0>;
+          };
...
quoted
+        mdio {
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          t1phy0: ethernet-phy@0{
+            reg = <0x0>;
+          };
Does this pass Rob's DT schema proof tools? You don't have any
description of the mdio properties.
Good catch. It will pass ATM only because 'unevaluatedProperties' is not 
yet implemented (should be in place soon). So it needs:

mdio:
  $ref: /schemas/net/mdio.yaml#
  unevaluatedProperties: false

Otherwise, this looks fine.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help