Re: [PATCH] net: sfp: add quirk for Finisar FTLF8536P4BCL
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-10-18 14:47:18
Also in:
lkml
On Wed, Oct 13, 2021 at 12:45:42PM +0200, Paul Menzel wrote:
From: Taras Chornyi <redacted> Finisar FTLF8536P4BCL can operate at 1000base-X and 10000base-SR, but reports 25G & 100GBd SR in it's EEPROM. Signed-off-by: Vadym Kochan <redacted> Signed-off-by: Taras Chornyi <redacted> [Upstream from https://github.com/dentproject/dentOS/pull/133/commits/b87b10ef72ea4638e80588facf3c9c2c1be67b40] Signed-off-by: Paul Menzel <redacted>
Thanks Vadym for the eeprom dump.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c index 7362f8c3271c..162b4030a863 100644 --- a/drivers/net/phy/sfp-bus.c +++ b/drivers/net/phy/sfp-bus.c@@ -55,6 +55,13 @@ static void sfp_quirk_ubnt_uf_instant(const struct sfp_eeprom_id *id, phylink_set(modes, 1000baseX_Full); } +static void sfp_quirk_finisar_25g(const struct sfp_eeprom_id *id, + unsigned long *modes) +{ + phylink_set(modes, 1000baseX_Full); + phylink_set(modes, 10000baseSR_Full); +}
I'd ask that this is named "sfp_quirk_1g10g()" please - it isn't doing anything that is specific to Finisar, it is merely stating that 1000base-X and 10000base-SR are supported.
+ }, {
+ // Finisar FTLF8536P4BCL can operate at 1000base-X and 10000base-SR,
+ // but reports 25G & 100GBd SR in it's EEPROMThis file doesn't wrap over column 80, so please continue to keeping it that way. // Finisar FTLF8536P4BCL can operate at 1000base-X and // 10000base-SR, but reports 25G & 100GBd SR in it's EEPROM Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!