Re: [PATCH net-next v2 1/4] dt-bindings: dmaengine: bam_dma: Add "powered remotely" mode
From: Bhupesh Sharma <hidden>
Date: 2021-10-18 11:34:46
Also in:
dmaengine, linux-arm-msm, linux-devicetree, lkml, phone-devel
Hi Stephan, On Mon, 11 Oct 2021 at 20:12, Stephan Gerhold [off-list ref] wrote:
In some configurations, the BAM DMA controller is set up by a remote
processor and the local processor can simply start making use of it
without setting up the BAM. This is already supported using the
"qcom,controlled-remotely" property.
However, for some reason another possible configuration is that the
remote processor is responsible for powering up the BAM, but we are
still responsible for initializing it (e.g. resetting it etc). Add
a "qcom,powered-remotely" property to describe that configuration.
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
Changes since RFC:
- Rename qcom,remote-power-collapse -> qcom,powered-remotely
for consistency with "qcom,controlled-remotely"
NOTE: This is *not* a compile-time requirement for the BAM-DMUX driver
so this could also go through the dmaengine tree.
Also note that there is an ongoing effort to convert these bindings
to DT schema but sadly there were not any updates for a while. :/
https://lore.kernel.org/linux-arm-msm/20210519143700.27392-2-bhupesh.sharma@linaro.org/ (local)Seems you missed the latest series posted last week - [1]. Sorry I got a bit delayed posting it due to being caught up in other patches. Maybe you can rebase your patch on the same and use the YAML bindings for the qcom,bam_dma controller. [1]. https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/T/#t (local) Regards, Bhupesh
quoted hunk ↗ jump to hunk
--- Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++ 1 file changed, 2 insertions(+)diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt index cf5b9e44432c..6e9a5497b3f2 100644 --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt@@ -15,6 +15,8 @@ Required properties: the secure world. - qcom,controlled-remotely : optional, indicates that the bam is controlled by remote proccessor i.e. execution environment. +- qcom,powered-remotely : optional, indicates that the bam is powered up by + a remote processor but must be initialized by the local processor. - num-channels : optional, indicates supported number of DMA channels in a remotely controlled bam. - qcom,num-ees : optional, indicates supported number of Execution Environments --2.33.0