Re: [PATCH net] can: j1939: fix errant alert in j1939_tp_rxtimer
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-10-17 10:41:02
Also in:
linux-can, lkml
On 06.09.2021 17:42:19, Ziyang Xuan wrote:
When the session state is J1939_SESSION_DONE, j1939_tp_rxtimer() will give an alert "rx timeout, send abort", but do nothing actually. Move the alert into session active judgment condition, it is more reasonable. One of the scenarioes is that j1939_tp_rxtimer() execute followed by
scenarios Typo fixed while applying.
j1939_xtp_rx_abort_one(). After j1939_xtp_rx_abort_one(), the session
state is J1939_SESSION_DONE, then j1939_tp_rxtimer() give an alert.
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Signed-off-by: Ziyang Xuan <redacted>Added to linux-can/testing, added stable on Cc. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachments
- signature.asc [application/pgp-signature] 488 bytes