Re: [PATCH net-next] net: marvell: prestera: add firmware v4.0 support

Hi Volodymyr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Volodymyr-Mytnyk/net-marvell-prestera-add-firmware-v4-0-support/20211015-225941
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 40088915f547b52635f022c1e1e18df65ae3153a
config: arm-randconfig-r024-20211015 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a49f5386ce6b091da66ea7c3a1d9a588d53becf7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/af0e1a7d7646e639d30d05831aa0a5c4a1b22ff5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Volodymyr-Mytnyk/net-marvell-prestera-add-firmware-v4-0-support/20211015-225941
        git checkout af0e1a7d7646e639d30d05831aa0a5c4a1b22ff5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

quoted

drivers/net/ethernet/marvell/prestera/prestera_hw.c:786:5: warning: no previous prototype for function 'prestera_hw_port_state_set' [-Wmissing-prototypes]

   int prestera_hw_port_state_set(const struct prestera_port *port,
       ^
   drivers/net/ethernet/marvell/prestera/prestera_hw.c:786:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int prestera_hw_port_state_set(const struct prestera_port *port,
   ^
   static 
   1 warning generated.


vim +/prestera_hw_port_state_set +786 drivers/net/ethernet/marvell/prestera/prestera_hw.c

e1189d9a5fbec8 Vadym Kochan 2020-09-16  785  
501ef3066c89d7 Vadym Kochan 2020-09-16 @786  int prestera_hw_port_state_set(const struct prestera_port *port,
501ef3066c89d7 Vadym Kochan 2020-09-16  787  			       bool admin_state)
501ef3066c89d7 Vadym Kochan 2020-09-16  788  {
501ef3066c89d7 Vadym Kochan 2020-09-16  789  	struct prestera_msg_port_attr_req req = {
501ef3066c89d7 Vadym Kochan 2020-09-16  790  		.attr = PRESTERA_CMD_PORT_ATTR_ADMIN_STATE,
501ef3066c89d7 Vadym Kochan 2020-09-16  791  		.port = port->hw_id,
501ef3066c89d7 Vadym Kochan 2020-09-16  792  		.dev = port->dev_id,
501ef3066c89d7 Vadym Kochan 2020-09-16  793  		.param = {
501ef3066c89d7 Vadym Kochan 2020-09-16  794  			.admin_state = admin_state,
501ef3066c89d7 Vadym Kochan 2020-09-16  795  		}
501ef3066c89d7 Vadym Kochan 2020-09-16  796  	};
501ef3066c89d7 Vadym Kochan 2020-09-16  797  
501ef3066c89d7 Vadym Kochan 2020-09-16  798  	return prestera_cmd(port->sw, PRESTERA_CMD_TYPE_PORT_ATTR_SET,
501ef3066c89d7 Vadym Kochan 2020-09-16  799  			    &req.cmd, sizeof(req));
501ef3066c89d7 Vadym Kochan 2020-09-16  800  }
501ef3066c89d7 Vadym Kochan 2020-09-16  801  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org