Thread (3 messages) flat view 3 messages, 3 authors, 2021-10-14

Re: [PATCH net] sctp: account stream padding length for reconf chunk

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-14 14:30:15
Also in: lkml

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski [off-list ref]:

On Wed, 13 Oct 2021 17:27:29 -0300 you wrote:
From: Eiichi Tsukata <redacted>

sctp_make_strreset_req() makes repeated calls to sctp_addto_chunk()
which will automatically account for padding on each call. inreq and
outreq are already 4 bytes aligned, but the payload is not and doing
SCTP_PAD4(a + b) (which _sctp_make_chunk() did implicitly here) is
different from SCTP_PAD4(a) + SCTP_PAD4(b) and not enough. It led to
possible attempt to use more buffer than it was allocated and triggered
a BUG_ON.

[...]
Here is the summary with links:
  - [net] sctp: account stream padding length for reconf chunk
    https://git.kernel.org/netdev/net/c/a2d859e3fc97

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help