[PATCH] include: marvell: octeontx2: build error: unknown type name 'u64'

Subsystems: marvell crypto driver, marvell octeontx2 physical function driver, the rest

STALE1767d LANDED

Landed in mainline as 6312d52838b2 on 2021-10-13.

3 messages, 2 authors, 2021-10-13 · open the first message on its own page

[PATCH] include: marvell: octeontx2: build error: unknown type name 'u64'

From: Anders Roxell <hidden>
Date: 2021-10-13 13:58:00

Building an allmodconfig kernel arm64 kernel, the following build error
shows up:

In file included from drivers/crypto/marvell/octeontx2/cn10k_cpt.c:4:
include/linux/soc/marvell/octeontx2/asm.h:38:15: error: unknown type name 'u64'
   38 | static inline u64 otx2_atomic64_fetch_add(u64 incr, u64 *ptr)
      |               ^~~

Include linux/types.h in asm.h so the compiler knows what the type
'u64' are.

Fixes: af3826db74d1 ("octeontx2-pf: Use hardware register for CQE count")
Signed-off-by: Anders Roxell <redacted>
---
 include/linux/soc/marvell/octeontx2/asm.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/linux/soc/marvell/octeontx2/asm.h b/include/linux/soc/marvell/octeontx2/asm.h
index 0f79fd7f81a1..d683251a0b40 100644
--- a/include/linux/soc/marvell/octeontx2/asm.h
+++ b/include/linux/soc/marvell/octeontx2/asm.h
@@ -5,6 +5,7 @@
 #ifndef __SOC_OTX2_ASM_H
 #define __SOC_OTX2_ASM_H
 
+#include <linux/types.h>
 #if defined(CONFIG_ARM64)
 /*
  * otx2_lmt_flush is used for LMT store operation.
-- 
2.33.0

Re: [PATCH] include: marvell: octeontx2: build error: unknown type name 'u64'

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-10-13 15:40:24

On Wed, 13 Oct 2021 15:57:43 +0200 Anders Roxell wrote:
Building an allmodconfig kernel arm64 kernel, the following build error
shows up:

In file included from drivers/crypto/marvell/octeontx2/cn10k_cpt.c:4:
include/linux/soc/marvell/octeontx2/asm.h:38:15: error: unknown type name 'u64'
   38 | static inline u64 otx2_atomic64_fetch_add(u64 incr, u64 *ptr)
      |               ^~~

Include linux/types.h in asm.h so the compiler knows what the type
'u64' are.

Fixes: af3826db74d1 ("octeontx2-pf: Use hardware register for CQE count")
Signed-off-by: Anders Roxell <redacted>
Yes, please! I've been carrying same patch locally. Any expectations on
who should apply the patch? I'm gonna send a PR with networking fixes
to Linus tomorrow, happy to take it via netdev if that's okay.

Re: [PATCH] include: marvell: octeontx2: build error: unknown type name 'u64'

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-10-13 20:27:10

On Wed, 13 Oct 2021 08:40:20 -0700 Jakub Kicinski wrote:
On Wed, 13 Oct 2021 15:57:43 +0200 Anders Roxell wrote:
quoted
Building an allmodconfig kernel arm64 kernel, the following build error
shows up:

In file included from drivers/crypto/marvell/octeontx2/cn10k_cpt.c:4:
include/linux/soc/marvell/octeontx2/asm.h:38:15: error: unknown type name 'u64'
   38 | static inline u64 otx2_atomic64_fetch_add(u64 incr, u64 *ptr)
      |               ^~~

Include linux/types.h in asm.h so the compiler knows what the type
'u64' are.

Fixes: af3826db74d1 ("octeontx2-pf: Use hardware register for CQE count")
Signed-off-by: Anders Roxell <redacted>  
Yes, please! I've been carrying same patch locally. Any expectations on
who should apply the patch? I'm gonna send a PR with networking fixes
to Linus tomorrow, happy to take it via netdev if that's okay.
I realized the breakage only exists in net-next so applied 
the fix there. Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help